function types: optional and vararg arguments. #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprobst
force-pushed
the
optional-arg
branch
from
d004209 to
1244f73
Compare
evmar
approved these changes
Nov 10, 2017
| @@ -6,7 +6,9 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
| import {expect} from 'chai'; | |||
| import {expect, use as chaiUse} from 'chai'; | |||
| // tslint:disable-next-line:no-require-imports chai-diff needs a CommonJS import. | |||
There was a problem hiding this comment.
How come? You can
import * as chaiDiff from 'chai-diff';
and then use it as a function.
There was a problem hiding this comment.
There's a wontfix TypeScript issue about it:
microsoft/TypeScript#5073
| @@ -35,6 +35,7 @@ | |||
| "@types/source-map": "^0.5.1", | |||
| "@types/source-map-support": "^0.2.27", | |||
| "chai": "^3.5.0", | |||
| "chai-diff": "^1.0.1", | |||
There was a problem hiding this comment.
This is good, but FWIW in my experience it's easier to just let the thing write out new goldens and examine the output with 'git diff'.
There was a problem hiding this comment.
When I'm interactively tweaking the emit, I find it much easier to see a good diff there than re-gen the goldens. That also runs a high risk of missing a change. But I understand workflows are different.
mprobst
force-pushed
the
optional-arg
branch
2 times, most recently
from
20ca325 to
44fc351
Compare
Previously, this would dump two long strings including escaped newlines and quotes, which made it ~impossible to tell the difference.
Previously, tsickle would support optional and varag arguments in function declarations (`@param` tags etc), but not in pure function types.
mprobst
force-pushed
the
optional-arg
branch
from
44fc351 to
b09b0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.